Addressing multiple TODO's since no one else did#170
Open
ApfelTeeSaft wants to merge 2 commits intohedge-dev:mainfrom
Open
Addressing multiple TODO's since no one else did#170ApfelTeeSaft wants to merge 2 commits intohedge-dev:mainfrom
ApfelTeeSaft wants to merge 2 commits intohedge-dev:mainfrom
Conversation
1. test_recompiler.cpp:216 - Implement CR register checking - Added proper CR register validation that checks all 4 fields (lt, gt, eq, so) - Each field is extracted from the 4-bit CR value using bit shifts 2. recompiler.h:55 - Create RecompileArgs struct - Introduced RecompileArgs struct to encapsulate the 7 function parameters - Improves code maintainability and reduces function signature complexity - Updated function signature and call site accordingly 3. recompiler.cpp:366 - Add bounds checking for mmioStore - Added validation to ensure the next instruction (data + 1) is within function bounds - Prevents potential out-of-bounds memory access 4. recompiler.cpp:1258 - Fix MFOCRF hardcoded CR field - Implemented proper FXM field mask decoding to determine which CR field to read - Removed hardcoded cr6 and now dynamically selects the correct CR field (cr0-cr7) - FXM is decoded as an 8-bit mask where bit 0 (0x80) = cr0, bit 1 (0x40) = cr1, etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_recompiler.cpp:216 - Implement CR register checking
recompiler.h:55 - Create RecompileArgs struct
recompiler.cpp:366 - Add bounds checking for mmioStore
recompiler.cpp:1258 - Fix MFOCRF hardcoded CR field